Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fields not supported #405

Closed
pavlexander opened this issue Sep 24, 2023 · 2 comments
Closed

fields not supported #405

pavlexander opened this issue Sep 24, 2023 · 2 comments
Assignees
Milestone

Comments

@pavlexander
Copy link

pavlexander commented Sep 24, 2023

Issue description

is there an apparent reason why fields are not supported?

For example when saving the data:

       var toSave = new List<MyParquetTest>
            {
                new MyParquetTest()
                {
                    Name = 0
                }
            };
            string file = @"D:\temp\performanceTests\test.parquet";
            await ParquetSerializer.SerializeAsync(toSave, file);

it will work just fine for the following class file with properties

       public class MyParquetTest
        {
            public int Name { get; set; }
        }

but for the struct with fields

        public struct MyParquetTest
        {
            public int Name;
        }

exception is thrown

System.ArgumentException: at least one field is required (Parameter 'fields')

would it be possible to add fields support? I feel like this is a needed feature, especially in the context of structs which by default usually do not contain properties.

@aloneguid
Copy link
Owner

Technically there's no reason, mostly lack of time ;)

@aloneguid aloneguid self-assigned this Jan 17, 2024
@aloneguid aloneguid added this to the 4.23.0 milestone Jan 17, 2024
@aloneguid
Copy link
Owner

This is fixed in 4.23.0, please feel free to validate and re-open if any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants