Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add positionIntent to Order object #539

Closed
1 task done
Brett55 opened this issue Dec 18, 2024 · 4 comments · Fixed by #540 or #541
Closed
1 task done

Add positionIntent to Order object #539

Brett55 opened this issue Dec 18, 2024 · 4 comments · Fixed by #540 or #541

Comments

@Brett55
Copy link

Brett55 commented Dec 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

Yes, I cannot filter on positionIntent when I fetch open order objects.

Describe the solution you'd like.

Add positionIntent attribute to the order object.
https://github.com/alpacahq/alpaca-py/blob/master/alpaca/trading/models.py#L167

Describe an alternate solution.

No response

Anything else? (Additional Context)

Yes, add positionIntent to https://github.com/alpacahq/alpaca-py/blob/master/alpaca/trading/requests.py#L169
as well.

@Brett55
Copy link
Author

Brett55 commented Dec 20, 2024

@hiohiohio how long does it take to see this change in pypi ?

@hiohiohio hiohiohio linked a pull request Dec 20, 2024 that will close this issue
@hiohiohio
Copy link
Contributor

@Brett55 I have noticed an issue of current implementation. Need to wait #541 merged.

@hiohiohio
Copy link
Contributor

@Brett55 released as v0.35.0. also available in pypi https://pypi.org/project/alpaca-py/0.35.0/

@projects2080
Copy link

@hiohiohio can it be added to the Order object in TradeUpdate stream event? Seems like a significant omission otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants