Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation of await self._consume() in stream.py #638

Open
3 tasks done
PBbanana opened this issue Jul 8, 2022 · 0 comments
Open
3 tasks done

Indentation of await self._consume() in stream.py #638

PBbanana opened this issue Jul 8, 2022 · 0 comments

Comments

@PBbanana
Copy link

PBbanana commented Jul 8, 2022

Question form pre-submit checklist.

  • I have searched the existing issues to ensure there isn't already an issue about this question.
  • My question has to do with the Python SDK and isn't a general question about the API. (If it is please open your issue here)
  • My question isn't about how to do a specific algorithm or asking for trade advice (answers to these are outside the scope of this repo).

Question

Hi,

This may or may not be a bug, I am only getting acquainted with asyncio. I notice an 'inconsistent' indentation in the file stream.py, and wanted to bring it up in case it is an error.

The command 'await self._consume()' is invoked twice, both times inside the definition of a _run_forever function. Both of these functions are pretty similar, as expected.

In line 254, 'await self._consume()' is outside an if statement and therefore always run in the while loop. In contrast,
in line 713, 'await self._consume()' is inside an if statement, and therefore, I assume, not necessarily run.

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant