PR review

alpar-t · alpar-t · commit 4f3096323142 · 2018-07-17T14:45:30.000+03:00
diff --git a/buildSrc/src/main/groovy/org/elasticsearch/gradle/precommit/PrecommitTasks.groovy b/buildSrc/src/main/groovy/org/elasticsearch/gradle/precommit/PrecommitTasks.groovy
@@ -113,7 +113,6 @@ class PrecommitTasks {
             forbiddenApisCliJar 'de.thetaphi:forbiddenapis:2.5'
         }
         Task forbiddenApisCli = project.tasks.create('forbiddenApisCli')
-        project.ext.getForbiddenSignaturesFile = { name -> project.getForbiddenSignaturesFile(name) }
 
         project.sourceSets.forEach { sourceSet ->
             forbiddenApisCli.dependsOn(
@@ -155,7 +154,7 @@ class PrecommitTasks {
         return forbiddenApisCli
     }
 
-    private static File getForbiddenSignaturesFile(project, String name) {
+    private static File getForbiddenSignaturesFile(Project project, String name) {
         return project.rootProject.file('buildSrc/src/main/resources/forbidden/' + name + '.txt')
     }
 

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,6 @@ class PrecommitTasks {`
`113`	`113`	`forbiddenApisCliJar 'de.thetaphi:forbiddenapis:2.5'`
`114`	`114`	`}`
`115`	`115`	`Task forbiddenApisCli = project.tasks.create('forbiddenApisCli')`
`116`		`- project.ext.getForbiddenSignaturesFile = { name -> project.getForbiddenSignaturesFile(name) }`
`117`	`116`
`118`	`117`	`project.sourceSets.forEach { sourceSet ->`
`119`	`118`	`forbiddenApisCli.dependsOn(`
`@@ -155,7 +154,7 @@ class PrecommitTasks {`
`155`	`154`	`return forbiddenApisCli`
`156`	`155`	`}`
`157`	`156`
`158`		`- private static File getForbiddenSignaturesFile(project, String name) {`
	`157`	`+ private static File getForbiddenSignaturesFile(Project project, String name) {`
`159`	`158`	`return project.rootProject.file('buildSrc/src/main/resources/forbidden/' + name + '.txt')`
`160`	`159`	`}`
`161`	`160`