Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace homegrown Bitcoin RPC client with an off-the-shelf one #81

Closed
delbonis opened this issue Jun 28, 2024 · 2 comments · Fixed by #251
Closed

Replace homegrown Bitcoin RPC client with an off-the-shelf one #81

delbonis opened this issue Jun 28, 2024 · 2 comments · Fixed by #251
Assignees
Labels
refactor Reworking code to improve structure or performance

Comments

@delbonis
Copy link
Contributor

The Bitcoin RPC client in the btcio module was copied in from previous prototypes. It functions for basic purposes well enough, but it's lacking numerous useful features and has some code quality issues (excessive allocation, ad-hoc encoding/decoding of values, etc.). We should replace it with an existing mature Bitcoin RPC client library that's tested and trusted by other projects, providing an impl for the L1Client trait that wraps it.

@delbonis delbonis added the refactor Reworking code to improve structure or performance label Jun 28, 2024
@voidash voidash self-assigned this Jun 30, 2024
@voidash
Copy link
Contributor

voidash commented Jul 4, 2024

@delbonis i looked through https://github.com/sapio-lang/rust-bitcoincore-rpc-async. This is very close to the rust-bitcoincore-rpc project.
The discussion related to async version of bitcoincore-rpc on rust-bitcoin : rust-bitcoin/rust-bitcoincore-rpc#78

  • I ran the integration test present there with v27.99 of bitcoind and only those related to legacy wallet failed.
  • The latest commit was about 6 months ago
  • This project seems to be used by nomic, sapio other than that i couldn't find alot of usage through github code search feature

this seems like a potential replacement. But maybe we may need our own fork like nomic has done to fit our needs.

@storopoli
Copy link
Member

rust-bitcoind-json-rpc-client is being brought into the rust-bitcoin org: rust-bitcoin/rust-bitcoin#3225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment