Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull data from CSM state and appropriately create l1 segment #93

Closed
Tracked by #92
, #126
...
bewakes opened this issue Jul 5, 2024 · 1 comment · Fixed by #116
Closed
Tracked by #92
, #126
...

Pull data from CSM state and appropriately create l1 segment #93

bewakes opened this issue Jul 5, 2024 · 1 comment · Fixed by #116
Assignees
@delbonis
Labels
consensus Consensus-critical, high-sensitivity required enhancement New feature or request

Comments

@bewakes
Copy link
Contributor

bewakes commented Jul 5, 2024

L1Segment, while creating l2 block, is not created correctly. It accepts l1 headers and deposits and both are empty now. Deposits will be done in the near future but headers need to be populated properly.

Location : consensus-logic/src/duty_executor.rs::sign_and_store_block()
@bewakes bewakes mentioned this issue Jul 9, 2024
Closed
5 tasks
@delbonis delbonis self-assigned this Jul 11, 2024
@delbonis delbonis mentioned this issue Jul 11, 2024
Merged
@delbonis delbonis added enhancement New feature or request consensus Consensus-critical, high-sensitivity required labels Jul 15, 2024
@delbonis delbonis mentioned this issue Jul 17, 2024
Closed
2 tasks
@bewakes bewakes mentioned this issue Jul 17, 2024
Closed
1 task
@delbonis delbonis mentioned this issue Jul 29, 2024
Closed
2 tasks
@john-light
Copy link
Contributor

Closed as duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delbonis delbonis

Labels
consensus Consensus-critical, high-sensitivity required enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly create L1 segment from sequencer's view of L1 alpenlabs/strata
3 participants
@bewakes @john-light @delbonis