Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fail on iOS after update v3.0.2, react-native 0.71.8 , expo 48 #66

Closed
meabed opened this issue May 23, 2023 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@meabed
Copy link

meabed commented May 23, 2023

Hey πŸ‘‹
Thank you for releasing the update, while updating the package I encountered a build failure, please find the details:

react-native: 0.71.8
react-native-file-access: 3.0.2
Platform: iOS

Bug
Build Fail when compiling the app

β€Ί Copying   @react-native-firebase/crashlytics RNFBCrashlytics/RNFBCrashlytics.framework/Headers/RNFBCrashlytics-umbrella.h ➜ ios/Pods/Target/ Support/ Files/RNFBCrashlytics/RNFBCrashlytics-umbrella.h
β€Ί Compiling react-native-file-access Pods/ReactNativeFileAccess Β» ReactNativeFileAccess_vers.c
β€Ί Compiling react-native-file-access Pods/ReactNativeFileAccess Β» ReactNativeFileAccess-dummy.m
β€Ί Compiling react-native-file-access Pods/ReactNativeFileAccess Β» FileAccess.mm

❌  (node_modules/react-native-file-access/ios/FileAccess.mm:2:9)

  1 | #import "FileAccess.h"
> 2 | #import <ReactNativeFileAccess-Swift.h>
    |         ^ 'ReactNativeFileAccess-Swift.h' file not found
  3 |
  4 | @implementation FileAccess
  5 | FileAccessImpl *impl;

β€Ί Compiling @react-native-firebase/app Pods/RNFBApp Β» RCTConvert+FIRApp.m
β€Ί Signing   react-native Pods/React-hermes Β» reacthermes.framework

To reproduce
Install the packages and run the ios app

@meabed meabed added the bug Something isn't working label May 23, 2023
@alpha0010
Copy link
Owner

Hmm, that file is supposed to be generated by Xcode automatically. To confirm I understand correctly, this only occurs with expo, not plain RN?

@meabed
Copy link
Author

meabed commented May 23, 2023

Ah i see, I use expo and pre-build to react-native, so it's not expo-go its similar plain RN.

it's working on the version 2 -

I will reproduce and share example repo.

@meabed
Copy link
Author

meabed commented May 23, 2023

@alpha0010 Here is repo that contains the code to re-produce the issue: https://github.com/meabed/rxdb-react-native-demo

I think it's happening when using plugins with expo - I will test and post the updates here

@meabed
Copy link
Author

meabed commented May 23, 2023

@alpha0010 so i figured this is happening when you use static framework in pod file ( which is needed for firebase and crashlytics ) so maybe this is the reason this file was not generated.

  useFrameworks: 'static',

https://github.com/meabed/rxdb-react-native-demo/blob/master/ios/Podfile#L45

image

@alpha0010
Copy link
Owner

Thanks for your detailed analysis of this bug. As you can tell from commit history, launching new arch support has been rougher than I hoped.

@meabed
Copy link
Author

meabed commented May 23, 2023

Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants