You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently all the ServiceListeners::AttachmentXxxxUpdater classes queue up jobs using the AssetManagerUpdateAssetWorker which accepts a Hash of attributes which are determined at the time the job is queued up.
If we're going to re-use the logic in these updaters to update the attributes of all existing Whitehall attachment assets in Asset Manager, I think we're going to want to determine the attributes at job execution time. This is because we might be queueing up millions of jobs and it might be a long time before the ones at the back of the queue are executed.
The text was updated successfully, but these errors were encountered:
floehopper
changed the title
Change attachment updaters so they query the database at job execution time vs job queue time
Query the database at job execution time vs job queue time when updating attributes on Asset Manager assets
Mar 2, 2018
The attachment listeners/workers have been updated so that we only store an AttachmentData.id on the queue and look up the attributes at the time the job is processed:
I'm not sure it's easy/possible to really validate this is working as expected in production given that it's an internal change. So I'm going to close this issue.
@chrislo / @floehopper: Feel free to re-open it if there's more testing you want to do.
Currently all the
ServiceListeners::AttachmentXxxxUpdater
classes queue up jobs using theAssetManagerUpdateAssetWorker
which accepts aHash
of attributes which are determined at the time the job is queued up.If we're going to re-use the logic in these updaters to update the attributes of all existing Whitehall attachment assets in Asset Manager, I think we're going to want to determine the attributes at job execution time. This is because we might be queueing up millions of jobs and it might be a long time before the ones at the back of the queue are executed.
The text was updated successfully, but these errors were encountered: