Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query the database at job execution time vs job queue time when updating attributes on Asset Manager assets #507

Closed
floehopper opened this issue Mar 2, 2018 · 2 comments
Assignees

Comments

@floehopper
Copy link
Contributor

Currently all the ServiceListeners::AttachmentXxxxUpdater classes queue up jobs using the AssetManagerUpdateAssetWorker which accepts a Hash of attributes which are determined at the time the job is queued up.

If we're going to re-use the logic in these updaters to update the attributes of all existing Whitehall attachment assets in Asset Manager, I think we're going to want to determine the attributes at job execution time. This is because we might be queueing up millions of jobs and it might be a long time before the ones at the back of the queue are executed.

@chrisroos
Copy link
Contributor

@chrisroos
Copy link
Contributor

I'm not sure it's easy/possible to really validate this is working as expected in production given that it's an internal change. So I'm going to close this issue.

@chrislo / @floehopper: Feel free to re-open it if there's more testing you want to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants