Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear where to link Error summary to #155

Closed
joelanman opened this issue Aug 24, 2018 · 5 comments
Closed

Make it clear where to link Error summary to #155

joelanman opened this issue Aug 24, 2018 · 5 comments

Comments

@joelanman
Copy link
Contributor

It's not clear where the Error summary links should take people to

@nubz
Copy link

nubz commented Aug 29, 2018

This is a good point - the example used shows links to the error messages (e.g. href="#dob-error") - I have seen links to the form controls themselves and also the use of a data-focuses attribute to set the focus on the form control - is this all encapsulated in the new design system with use of the href values? On one pre-design system service I worked on the DAC review picked up our lack of setting focus on errored radio elements as a fail - also noticed the data-focuses attribute in summary links failed to automatically set focus on textareas.

@colinrotherham
Copy link

A collection of variations as seen on GOV.UK Elements:

Error summary links to <legend> id which focusses input
http://govuk-elements.herokuapp.com/errors/example-form-validation-single-question-radio
http://govuk-elements.herokuapp.com/errors/example-form-validation-single-question-more-text

Error summary links to <label> id which focusses input
http://govuk-elements.herokuapp.com/errors/example-form-validation-single-question-text

Error summary links to <input> id which receives focus
http://govuk-elements.herokuapp.com/errors/example-form-validation-multiple-questions

I can't see any patterns on the design system that have both the error summary and error message components used together. Would be great to see this.

@colinrotherham
Copy link

For anyone else that finds this ticket, there's a more thorough demo on GOV.UK Frontend (used by the design system) here: http://govuk-frontend-review.herokuapp.com/examples/error-summary

examples

@NickColley
Copy link
Contributor

Research done by @36degrees : https://36degrees.github.io/linking-to-form-inputs/results/

@36degrees
Copy link
Contributor

This was addressed in alphagov/govuk-design-system#634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants