Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button height #1441

Closed
abbott567 opened this issue Jan 5, 2021 · 5 comments
Closed

Button height #1441

abbott567 opened this issue Jan 5, 2021 · 5 comments

Comments

@abbott567
Copy link

The standard button component is 4px short of meeting the AAA criteria for target size on the height attribute. I know we only work to AA, but I noticed the radio buttons and checkboxes were increased to 44px, and 44px was presumably chosen for that reason?

The back link component also appears to leverage some :after css trickery to increase the target size above the threshold of 44px, presumably to hit the same WCAG criterion?

I'm wondering if the standard buttons have just been missed or if there is a deliberate design decision to keep them at 40px rather than 44px?

Thanks

Screenshot of button component

@joelanman
Copy link
Contributor

more discussion here:
alphagov/govuk-frontend#2060

@abbott567
Copy link
Author

Ah thanks @joelanman - I'm always unsure on what is a Design System issue and what is a GOVUK Frontend issue. Should have looked in both! Apologies.

@joelanman
Copy link
Contributor

no problem at all, it's hard to keep track of both

@36degrees
Copy link
Contributor

@abbott567 are you happy that issue covers this as well? If so, can we close this as a duplicate?

@abbott567
Copy link
Author

abbott567 commented Jan 5, 2021

Yeah, I think it does, as you specifically mentioned the buttons. Will close this in favour of: alphagov/govuk-frontend#2060. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants