-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button height #1441
Comments
more discussion here: |
Ah thanks @joelanman - I'm always unsure on what is a Design System issue and what is a GOVUK Frontend issue. Should have looked in both! Apologies. |
no problem at all, it's hard to keep track of both |
@abbott567 are you happy that issue covers this as well? If so, can we close this as a duplicate? |
Yeah, I think it does, as you specifically mentioned the buttons. Will close this in favour of: alphagov/govuk-frontend#2060. Thanks! |
The standard button component is 4px short of meeting the AAA criteria for target size on the height attribute. I know we only work to AA, but I noticed the radio buttons and checkboxes were increased to 44px, and 44px was presumably chosen for that reason?
The back link component also appears to leverage some
:after
css trickery to increase the target size above the threshold of 44px, presumably to hit the same WCAG criterion?I'm wondering if the standard buttons have just been missed or if there is a deliberate design decision to keep them at 40px rather than 44px?
Thanks
The text was updated successfully, but these errors were encountered: