Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ConfigurableComponent in the Design System's Cookie Banner #4275

Closed
1 task
Tracked by #5373
romaricpascal opened this issue Nov 4, 2024 · 0 comments · Fixed by #4305
Closed
1 task
Tracked by #5373

Use ConfigurableComponent in the Design System's Cookie Banner #4275

romaricpascal opened this issue Nov 4, 2024 · 0 comments · Fixed by #4305

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Nov 4, 2024 •
edited
Loading

What

Use a preview branch of govuk-frontend to spike an update of the CookieBanner component to use the ConfigurableComponent class added by alphagov/govuk-frontend#5456 for receiving its cookieCategory and verify it works as we intend.

Why

So we can check the feature works as we intended it to and assess any unforeseen impact

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • We've updated CookieBanner to use the new ConfigurableComponent class
@romaricpascal romaricpascal mentioned this issue Nov 4, 2024
Closed
@romaricpascal romaricpascal transferred this issue from alphagov/govuk-frontend Nov 4, 2024
@romaricpascal romaricpascal changed the title Use getConfiguration in the Design System's Cookie Banner Use getComponentConfiguration in the Design System's Cookie Banner Nov 4, 2024
@romaricpascal romaricpascal changed the title Use getComponentConfiguration in the Design System's Cookie Banner Use ConfigurableComponent in the Design System's Cookie Banner Nov 7, 2024
@romaricpascal romaricpascal moved this to In progress 📝 in GOV.UK Design System cycle board Nov 7, 2024
@romaricpascal romaricpascal moved this from In progress 📝 to Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Nov 7, 2024
@romaricpascal romaricpascal mentioned this issue Nov 7, 2024
Closed
1 task
Merged
@Izabela-16 Izabela-16 moved this from Backlog 🏃🏼‍♀️ to Ready to release 🚀 in GOV.UK Design System cycle board Nov 18, 2024
@domoscargin domoscargin moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GOV.UK Design System cycle board
Status: Done 🏁
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cookie banner extends ConfigurableComponent alphagov/govuk-design-system
1 participant
@romaricpascal