Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs focus state cropped in IE11 #1472

Closed
hannalaakso opened this issue Jun 24, 2019 · 2 comments · Fixed by #1496
Closed

Tabs focus state cropped in IE11 #1472

hannalaakso opened this issue Jun 24, 2019 · 2 comments · Fixed by #1496
Assignees
@36degrees
Milestone
v3.0.0

Comments

@hannalaakso
Copy link
Member

IE11 in Browserstack shows the focus correctly but in IE11 on native Windows 7 and 10 the focus appears cropped:

tabs-ie11

Edge on native Windows 10 displays the focus state correctly.
@hannalaakso hannalaakso added the awaiting triage Needs triaging by team label Jun 24, 2019
@hannalaakso hannalaakso self-assigned this Jun 25, 2019
@hannalaakso
Copy link
Member Author

This could be related to #1469 (comment), although I can't replicate this on Chrome on Windows.

@timpaul timpaul removed the awaiting triage Needs triaging by team label Jun 26, 2019
@36degrees 36degrees added this to the v3.0.0 milestone Jul 4, 2019
@kellylee-gds kellylee-gds mentioned this issue Jul 4, 2019
Closed
34 tasks
@hannalaakso
Copy link
Member Author

It doesn't look like this is related to #1469 (comment). It's more likely because the way we do the focus state for the tabs is quite a complex use of box shadow (to avoid a breaking change).

@hannalaakso hannalaakso removed their assignment Jul 9, 2019
@36degrees 36degrees self-assigned this Jul 12, 2019
@36degrees 36degrees mentioned this issue Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@36degrees 36degrees

Labels
None yet
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Update tab focus state alphagov/govuk-frontend
3 participants
@36degrees @timpaul @hannalaakso