Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate applying JavaScript conventions within GOV.UK Frontend #1720

Closed
1 of 5 tasks
Tracked by #1722
hannalaakso opened this issue Jan 30, 2020 · 1 comment
Closed
1 of 5 tasks
Tracked by #1722

Comments

@hannalaakso
Copy link
Member

hannalaakso commented Jan 30, 2020

What

Try applying some of the approaches we saw in #1719 with GOV.UK Frontend to help us decide what approach to take and/or to ensure they work for us.

Why

So we can be confident in our decisions. So we understand how the approaches apply to our JavaScript in GOV.UK Frontend.

Who needs to know about this

Developers

Depends on

Done when

  • Made a note of our existing conventions - do we want to keep these?
  • Draft questions that we want this work to answer
  • We've tried out some viable approaches
  • Decision made on the conventions we want to follow
@vanitabarrett vanitabarrett changed the title Prototype ways to access to "public" JavaScript methods and variables and to define methods/variables as "private" Spike/investigate JavaScript conventions within GOV.UK Frontend Feb 28, 2022
@vanitabarrett vanitabarrett changed the title Spike/investigate JavaScript conventions within GOV.UK Frontend Investigate applying JavaScript conventions within GOV.UK Frontend Feb 28, 2022
@36degrees
Copy link
Contributor

Closing, although we should make sure we're including this as part of our 'done when' criteria other JavaScript related work

@36degrees 36degrees closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants