Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document date input change from type="number" to inputmode="numeric" in next breaking release #1829

Closed
hannalaakso opened this issue Jun 3, 2020 · 1 comment
Closed

Document date input change from type="number" to inputmode="numeric" in next breaking release #1829

hannalaakso opened this issue Jun 3, 2020 · 1 comment
Labels
date input documentation User requests new documentation or improvements to existing documentation

Comments

@hannalaakso
Copy link
Member

We made a markup change to the date input component from <input […] type="number" pattern="[0-9]*"> to <input […] type="text" inputmode="numeric" pattern="[0-9]*"> in #1704.

Since the change was in a non-breaking release we treated it as an enhancement and didn't document steps for making the change in the release note. However we should document the steps to make this change in people's projects in the release note of the next breaking release.
@hannalaakso hannalaakso added documentation User requests new documentation or improvements to existing documentation date input labels Jun 3, 2020
@hannalaakso hannalaakso added this to the v4.0.0 milestone Jun 3, 2020
@vanitabarrett vanitabarrett removed this from the v4.0.0 milestone Aug 24, 2021
@vanitabarrett vanitabarrett mentioned this issue Sep 8, 2021
Closed
4 tasks
@36degrees
Copy link
Contributor

This was included as a recommended change in the release notes for v4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
date input documentation User requests new documentation or improvements to existing documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@36degrees @hannalaakso @vanitabarrett