Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about links styled as buttons to cookie macros #2166

Closed
4 tasks done
EoinShaughnessy opened this issue Mar 9, 2021 · 5 comments · Fixed by #2168
Closed
4 tasks done

Add info about links styled as buttons to cookie macros #2166

EoinShaughnessy opened this issue Mar 9, 2021 · 5 comments · Fixed by #2168
Assignees
Labels
documentation User requests new documentation or improvements to existing documentation

Comments

@EoinShaughnessy
Copy link
Contributor

EoinShaughnessy commented Mar 9, 2021

What

Update cookie banner macro options to explain how users can render a link styled as a button.

Why

This option could help users if:

  • their cookie banner needs to work without JavaScript
  • they have already accepted or rejected cookies - so, when they press Hide and the page reloads, the banner is hidden

PR with technical details about this change: Enable cookie banner to set link styled as a button

Who needs to know about this

Delivery Manager, Developers, Technical Writer

Done when

  • Developer drafts update
  • Technical Writer reviews update and actions any further changes
  • Technical Writer gets update 2i'd
  • Update published
@EoinShaughnessy EoinShaughnessy added documentation User requests new documentation or improvements to existing documentation awaiting triage Needs triaging by team labels Mar 9, 2021
@EoinShaughnessy
Copy link
Contributor Author

@EoinShaughnessy EoinShaughnessy removed the awaiting triage Needs triaging by team label Mar 9, 2021
@vanitabarrett
Copy link
Contributor

Do we also need to update the description for the following option?

description: The `href` for a link. If you set `href`, users will see a link instead of a button.

@EoinShaughnessy
Copy link
Contributor Author

Do we also need to update the description for the following option?

description: The `href` for a link. If you set `href`, users will see a link instead of a button.

Great shout! As a replacement for what's currently there, could something like the below work?

The href for a link. Set button and href to render a link styled as a button.

Would we need to say anything about href overriding submit?

@vanitabarrett
Copy link
Contributor

@EoinShaughnessy That sounds good to me. I'm not sure if we'd need to mention submit - it feels like it might be covered in the type description?

@EoinShaughnessy
Copy link
Contributor Author

@vanitabarrett Ah yes, of course. Cool, I'll raise a PR with these changes. Once I get dev sign-off, I'll send the content changes for 2i.

@EoinShaughnessy EoinShaughnessy linked a pull request Mar 9, 2021 that will close this issue
@36degrees 36degrees added this to the v3.12.0 milestone Mar 10, 2021
@hannalaakso hannalaakso removed this from the v3.12.0 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation User requests new documentation or improvements to existing documentation
Projects
Development

Successfully merging a pull request may close this issue.

4 participants