Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer OGL logo not visible in windows high contrast mode (flagged in an accessibility audit) #2272

Closed
oscarduignan opened this issue Jul 8, 2021 · 1 comment · Fixed by #2273
Labels
accessibility 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) footer 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Milestone

Comments

@oscarduignan
Copy link
Contributor

Description of the issue

when you are in windows high contrast mode and view the govuk footer in edge, you inherit svg { forced-color-adjust: none; } from the user agent stylesheet which causes the license-logo in the footer to be invisible because the fill and the background are now very close to the same colour.

CleanShot 2021-07-08 at 16 38 11@2x

Steps to reproduce the issue

turn on high contrast on windows and view the footer in edge

Actual vs expected behaviour

that the logo is visible, which could be done with media query targeting forced-colors and setting the color explicitly or by enabling the automatic behaviour of forced-color-adjust for this svg (example below where forced-color-adjust is set to auto - please note when I edited this in edge dev tools I had to close the dev tools and reopen them for some reason for this to apply, just in case you try to recreate the same way)

CleanShot 2021-07-08 at 16 39 36@2x

Environment (where applicable)

  • Operating system: Windows 10
  • Browser: Microsoft Edge
  • Browser version: Version 91.0.864.64 (Official build) (64-bit)
  • GOV.UK Frontend Version: latest as far as I can see
@oscarduignan oscarduignan added awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) labels Jul 8, 2021
@36degrees 36degrees added accessibility footer 🕔 hours A well understood issue which we expect to take less than a day to resolve. and removed awaiting triage Needs triaging by team labels Jul 8, 2021
@36degrees
Copy link
Contributor

Thanks for reporting this.

This looks like a regression introduced in Chromium 89 when forced colors mode was introduced – it works as expected in Edge 88.

My expectation was that even in forced color mode currentColor should still map to the text colour in which case the OGL logo should be white. It looks like this is an unfortunate side effect of an intentional spec decision (based on Chromium bug #1164162 and w3c/csswg-drafts#4915) but has been flagged as an issue with the CSSWG in w3c/csswg-drafts#6310.

As a result, there's a change to the spec which means hopefully this will be fixed in browsers 'soon'. But that's likely to take a while so in the meantime it seems like setting forced-color-adjust to auto on .govuk-footer__licence-logo as you've suggested does make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) footer 🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants