Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated govuk-header__link--service-name class #2636

Closed
2 tasks done
Tracked by #3524
36degrees opened this issue May 20, 2022 · 0 comments · Fixed by #3594
Closed
2 tasks done
Tracked by #3524

Remove deprecated govuk-header__link--service-name class #2636

36degrees opened this issue May 20, 2022 · 0 comments · Fixed by #3594
Assignees
Milestone

Comments

@36degrees
Copy link
Contributor

36degrees commented May 20, 2022

What

Remove the govuk-header__link--service-name class from the header component.

Tell users to replace instances of govuk-header__link--service-name with govuk-header__service-name.

Why

The govuk-header__link--service-name was deprecated in #2617 when the new equivalent class name govuk-header__service-name was introduced.

The govuk-header__link--service-name class was a modifier for links, but the other changes in the PR meant that it was no longer always going to be used on a link, so we renamed it.

Who needs to work on this

Developer, tech writer

Who needs to review this

Developer, tech writer

Done when

  • The govuk-header__link--service-name class has been removed
  • Breaking change documented in release notes with a clear path for migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants