Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated .govuk-header__navigation--no-service-name class #2695

Closed
2 tasks done
Tracked by #3524
querkmachine opened this issue Jul 14, 2022 · 0 comments · Fixed by #3595
Closed
2 tasks done
Tracked by #3524

Remove deprecated .govuk-header__navigation--no-service-name class #2695

querkmachine opened this issue Jul 14, 2022 · 0 comments · Fixed by #3595
Assignees
@querkmachine
Labels
breaking change header
Milestone
v5.0

Comments

@querkmachine
Copy link
Member

querkmachine commented Jul 14, 2022 •
edited
Loading

What

Reliant on this class having been deprecated in #2216.

Remove the deprecated .govuk-header__navigation--no-service-name class from our Sass in the next breaking release.

Why

This class serves a dubiously useful purpose and doesn't appear to have been used by any services that implement GOV.UK Frontend.

This class is not present in any of our documentation, nor is an example of it in the review app. There are no tests relevant to the existence or functionality of this class.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • Sass/CSS for this class has been removed
  • The changelog has been updated to note the removal
@querkmachine querkmachine added this to the v5.0 milestone Jul 20, 2022
@36degrees 36degrees mentioned this issue Apr 18, 2023
Closed
@querkmachine querkmachine self-assigned this May 9, 2023
@querkmachine querkmachine moved this from Backlog 🗄 to In progress 📝 in GOV.UK Design System cycle board May 9, 2023
@querkmachine querkmachine mentioned this issue May 9, 2023
Merged
@querkmachine querkmachine moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board May 9, 2023
@querkmachine querkmachine moved this from Needs review 🔍 to Ready to release 🚀 in GOV.UK Design System cycle board May 9, 2023
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@querkmachine querkmachine

Labels
breaking change header
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

Successfully merging a pull request may close this issue.

Remove deprecated govuk-header__navigation--no-service-name class alphagov/govuk-frontend
1 participant
@querkmachine