Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static spacing override classes don't start with govuk-!-static (as documented) #2771

Closed
3 tasks done
vanitabarrett opened this issue Aug 15, 2022 · 0 comments · Fixed by #2770
Closed
3 tasks done
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) ⚠️ high priority Used by the team when triaging
Milestone

Comments

@vanitabarrett
Copy link
Contributor

vanitabarrett commented Aug 15, 2022

Description of the issue

As raised by a user in the govuk-design-system repo, the static spacing override classes are not in the same format as they're documented. Classes should start with govuk-!-static, but instead are formatted like this: govuk-!-margin-static (for example).

Steps to reproduce the issue

Try and use govuk-!-static-margin-2 class - nothing will be applied.

Actual vs expected behaviour

govuk-!-margin-static-2 class (for example) should be govuk-!-static-margin-2

Environment (where applicable)

  • GOV.UK Frontend Version: 4.3.0

Done When

  • Raise a PR to add the new correct class, alongside the old class
  • Deprecate the old class
  • Create a ticket to remove the deprecated class in the next major release, and add it to the v5.0.0 milestone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) ⚠️ high priority Used by the team when triaging
Projects
Development

Successfully merging a pull request may close this issue.

1 participant