We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The tabs component binds the onTabClick and onTabKeydown listeners multiple times, while only a single version of that bound method is necessary.
onTabClick
onTabKeydown
Furthermore, it stores each bound version on the $tab element, poluting the object from the DOM.
$tab
These methods could be bound only once before looping and stored on the component instead.
Avoid unnecessary extra functions being created and poluting objects from the browser.
Developers
The text was updated successfully, but these errors were encountered:
Fixed by #2987 (478f642)
Sorry, something went wrong.
No branches or pull requests
What
The tabs component binds the
onTabClick
andonTabKeydown
listeners multiple times, while only a single version of that bound method is necessary.Furthermore, it stores each bound version on the
$tab
element, poluting the object from the DOM.These methods could be bound only once before looping and stored on the component instead.
Why
Avoid unnecessary extra functions being created and poluting objects from the browser.
Who needs to work on this
Developers
Who needs to review this
Developers
Done when
The text was updated successfully, but these errors were encountered: