Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep tracking impact of polyfills once automated #3283

Open
3 tasks
Tracked by #3948
romaricpascal opened this issue Feb 13, 2023 · 0 comments
Open
3 tasks
Tracked by #3948

Keep tracking impact of polyfills once automated #3283

romaricpascal opened this issue Feb 13, 2023 · 0 comments

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Feb 13, 2023

Part of #3279

Note This only applies if we start using Babel to automatically add polyfills to our components

What

Track which polyfills our modules need and how weighty they are after Babel adds them to our code when bundling our components.

Why

Currently, our polyfills are vendored in the package we ship. This means we're able to track their impact when looking at what's brought in when importing our modules. If we move to Babel to automatically import polyfills, we'll need to make sure we still keep track of the impact of our polyfills.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • We figured a way to collect polyfill impact1
  • We display impact in review app
  • We display impact in a PR comment

Footnotes

  1. This may be through running rollup-plugin-visualizer alongside our build so it picks up Babel's transformations, adding the same transformations to the stats collection or another mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants