Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the structure of our repository #3291

Closed
7 tasks done
romaricpascal opened this issue Feb 14, 2023 · 3 comments
Closed
7 tasks done

Enhance the structure of our repository #3291

romaricpascal opened this issue Feb 14, 2023 · 3 comments
Labels
epic Epics are used in planning project boards to group related stories javascript tooling

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Feb 14, 2023

What

We're reorganising the files in our repository to have a better to work with. See the issues for details about each move and its reason.

Why

A better structure for our repository allows us to:

  • acknowledge its monorepo nature (having both our library and the review app, alongside various helpers),
  • provide better isolation between the different parts of the project
  • avoid future breaking changes should we need dependencies
  • limit our use of relative paths when importing from each part of the project.

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

v5

  1. assurance consistency interoperability
  2. 4 of 4
    tooling
  3. 2 of 2
  4. 3 of 3
    romaricpascal

Future changes

  1. documentation tooling
  2. consistency dependencies interoperability
    colinrotherham
  3. consistency
    colinrotherham
@romaricpascal romaricpascal added epic Epics are used in planning project boards to group related stories javascript tooling labels Feb 14, 2023
@colinrotherham
Copy link
Contributor

colinrotherham commented Feb 15, 2023

Does committing ./package let other projects clone the repo (or use git submodules) to pull govuk-frontend and have all the files, pre-built, ready to go without needing an npm install or extra build steps?

Can see a bit of history in older releases:

<script src="{path-to-govuk-frontend}/all.js"></script>
<script>window.GOVUKFrontend.initAll()</script>

☝️ This release has details about the old namespaced package @govuk-frontend/frontend

@romaricpascal
Copy link
Member Author

Didn't think of cloning/submodules to access the source (and cheers for the issue archeology 😄).

That said, cloning govuk-frontend (or using it as submodule) to access package may not give you what you expect. If you clone main at the moment, you'll get the package from the last release, not the package corresponding to the source in main.

@romaricpascal
Copy link
Member Author

Linking #2886 to keep track of the related ongoing discussions around the reorganisation of ther repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic Epics are used in planning project boards to group related stories javascript tooling
Projects
Development

No branches or pull requests

4 participants