-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark internal classes and functions as @internal
#4017
Labels
Milestone
Comments
github-project-automation
bot
moved this to Backlog 🗄
in GOV.UK Design System cycle board
Jul 28, 2023
36degrees
moved this from Backlog 🗄
to Sprint Backlog 🏃🏼♀️
in GOV.UK Design System cycle board
Jul 28, 2023
2 tasks
Related PR (and commit) regarding comment removal for |
36degrees
moved this from Sprint Backlog 🏃🏼♀️
to In progress 📝
in GOV.UK Design System cycle board
Aug 7, 2023
36degrees
moved this from In progress 📝
to Needs review 🔍
in GOV.UK Design System cycle board
Aug 7, 2023
Split out into: |
romaricpascal
moved this from Needs review 🔍
to Ready to release 🚀
in GOV.UK Design System cycle board
Aug 11, 2023
36degrees
moved this from Ready to release 🚀
to Done 🏁
in GOV.UK Design System cycle board
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
Annotate all of our 'internal' classes or functions (like the I18n class and the mergeConfigs function) as
@internal
.Remove any other access annotations (like
@private
) from classes and functions. (Individual properties within an@internal
class can still be marked as private)Why
This is part of our decision to reset the public JavaScript API.
When using access related annotations we want to be clearer about whether the annotation refers to:
Using
@private
,@protected
and@public
only for describing class-level access helps with this.We can then use
@internal
(and potentially in the future the other release tags) for library level access annotations.Who needs to work on this
Developers
Who needs to review this
Developers
Done when
@internal
The text was updated successfully, but these errors were encountered: