Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move responsibilities from initAll to the components #4945

Closed
1 of 2 tasks
Tracked by #3731
36degrees opened this issue Apr 19, 2024 · 1 comment · Fixed by #4975 or alphagov/govuk-frontend-docs#443
Closed
1 of 2 tasks
Tracked by #3731

Move responsibilities from initAll to the components #4945

36degrees opened this issue Apr 19, 2024 · 1 comment · Fixed by #4975 or alphagov/govuk-frontend-docs#443
Assignees
@36degrees @romaricpascal @owenatgov
Milestone
5.4.0

Comments

@36degrees
Copy link
Contributor

36degrees commented Apr 19, 2024 •
edited by romaricpascal
Loading

What

Move as many responsibilities from initAll to the components so that initAll is doing as little as possible.

For example, the data-module selector is only defined in initAll.

Add any new methods to the JavaScript API reference

Why

To make it easier to include the JS for components without needing to import or use the initAll function.

Who needs to know about this

Developers

Done when

  • initAll does as little as possible.
  • Any new methods are clearly documented in the JavaScript API reference
@36degrees 36degrees mentioned this issue Apr 19, 2024
Closed
@36degrees 36degrees transferred this issue from alphagov/govuk-design-system Apr 19, 2024
@36degrees 36degrees moved this to Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Apr 19, 2024
@36degrees 36degrees moved this from Backlog 🏃🏼‍♀️ to In progress 📝 in GOV.UK Design System cycle board May 9, 2024
@36degrees 36degrees added this to the [next] milestone May 9, 2024
@36degrees 36degrees linked a pull request May 9, 2024 that will close this issue
Add createAll function to initialise individual components #4975
Merged
@36degrees 36degrees moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board May 9, 2024
@romaricpascal romaricpascal mentioned this issue May 10, 2024
Merged
@36degrees 36degrees moved this from Needs review 🔍 to Ready to release 🚀 in GOV.UK Design System cycle board May 10, 2024
@romaricpascal
Copy link
Member

Reopening waiting for alphagov/govuk-frontend-docs#443 to be merged.

@romaricpascal romaricpascal reopened this May 10, 2024
@36degrees 36degrees moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board May 17, 2024
@owenatgov owenatgov mentioned this issue May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@36degrees 36degrees

@romaricpascal romaricpascal

@owenatgov owenatgov

Labels
None yet
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
5.4.0
3 participants
@36degrees @romaricpascal @owenatgov