Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it worth adding aria expanded to details? #4972

Closed
joelanman opened this issue May 7, 2024 · 2 comments · Fixed by #5089
Closed

Is it worth adding aria expanded to details? #4972

joelanman opened this issue May 7, 2024 · 2 comments · Fixed by #5089
Labels
accessibility concern Bug, feature request or question about the accessibility of a portion of a product (not a WCAG fail) 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) details
Milestone
5.7.0

Comments

@joelanman
Copy link
Contributor

joelanman commented May 7, 2024 •
edited
Loading

Description of the issue

This issue is now very old, is it worth adding aria-expanded to details to fix it in Frontend instead?

Came up recently here:
@joelanman joelanman added awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) labels May 7, 2024
@querkmachine querkmachine added accessibility concern Bug, feature request or question about the accessibility of a portion of a product (not a WCAG fail) and removed awaiting triage Needs triaging by team labels Jun 13, 2024
@romaricpascal
Copy link
Member

Hi @joelanman, thanks for suggesting this. We currently cannot prioritise looking into this, but one thing that came to mind regarding the solution is that we'd not only need to make sure it fixes the issue for VoiceOver and Safari, but also doesn't negatively impact users with other browser/assisitive tech combinations.

@selfthinker selfthinker mentioned this issue Aug 9, 2024
Closed
@owenatgov owenatgov mentioned this issue Sep 23, 2024
Merged
@owenatgov
Copy link
Contributor

We did look into this and from some rough testing, it unfortunately didn't make a difference. The root problem however will be solved by #5089

@owenatgov owenatgov added this to the 5.7.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility concern Bug, feature request or question about the accessibility of a portion of a product (not a WCAG fail) 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) details
Projects
None yet
Milestone
5.7.0
Development

Successfully merging a pull request may close this issue.

Fix details expanded state not announced on iOS alphagov/govuk-frontend
4 participants
@romaricpascal @joelanman @querkmachine @owenatgov