Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add leading check to verify that GOV.UK Frontend is supported in createAll #5213

Closed
1 task done
Tracked by #5205
romaricpascal opened this issue Aug 9, 2024 · 1 comment · Fixed by #5251
Closed
1 task done
Tracked by #5205

Add leading check to verify that GOV.UK Frontend is supported in createAll #5213

romaricpascal opened this issue Aug 9, 2024 · 1 comment · Fixed by #5251
Assignees
@patrickpatrickpatrick
Labels
javascript

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Aug 9, 2024 •
edited by patrickpatrickpatrick
Loading

What

Similarly to what initAll does, add a leading check to createAll to verify that GOV.UK Frontend is supported before looping on components.

Why

To avoid unnecessary looping

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • createAll bails early if GOV.UK Frontend is not supported
@romaricpascal romaricpascal mentioned this issue Aug 9, 2024
Closed
@romaricpascal romaricpascal moved this to Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Aug 9, 2024
@patrickpatrickpatrick patrickpatrickpatrick self-assigned this Aug 19, 2024
Merged
@romaricpascal romaricpascal moved this from Backlog 🏃🏼‍♀️ to Ready to release 🚀 in GOV.UK Design System cycle board Aug 20, 2024
@romaricpascal
Copy link
Member Author

Merged on the public-js-api branch so we can close this issue.

@romaricpascal romaricpascal linked a pull request Aug 20, 2024 that will close this issue
Add isSupported to createAll #5251
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickpatrickpatrick patrickpatrickpatrick

Labels
javascript
Projects
GOV.UK Design System cycle board
Status: Ready to release 🚀
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add isSupported to createAll alphagov/govuk-frontend
2 participants
@romaricpascal @patrickpatrickpatrick