Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor errors prefixed by the component name to use formatErrorMessage #5325

Closed
2 tasks
Tracked by #5292
romaricpascal opened this issue Sep 16, 2024 · 0 comments · Fixed by #5358
Closed
2 tasks
Tracked by #5292

Refactor errors prefixed by the component name to use formatErrorMessage #5325

romaricpascal opened this issue Sep 16, 2024 · 0 comments · Fixed by #5358
Assignees
@romaricpascal

Comments

@romaricpascal
Copy link
Member

romaricpascal commented Sep 16, 2024 •
edited
Loading

What

Refactor other errors whose message is currently formatted as <COMPONENT_NAME>: <ERROR_MESSAGE to use formatErrorMessage

Why

This will make the error formatting consistent across the project

Who needs to work on this

Developers

Who needs to review this

Developers

Done when

  • This list has been updated with an inventory of the errors that need updating
  • The errors have been updated to use the formatErrorMessage helper
@romaricpascal romaricpascal mentioned this issue Sep 16, 2024
Closed
@romaricpascal romaricpascal changed the title Refactor other errors to follow the convetion Refactor errors prefixed by the component name to use formatErrorMessage Sep 16, 2024
@romaricpascal romaricpascal moved this to Backlog 🏃🏼‍♀️ in GOV.UK Design System cycle board Sep 16, 2024
@romaricpascal romaricpascal self-assigned this Sep 27, 2024
@romaricpascal romaricpascal mentioned this issue Sep 27, 2024
Merged
@romaricpascal romaricpascal moved this from Backlog 🏃🏼‍♀️ to Ready to release 🚀 in GOV.UK Design System cycle board Oct 7, 2024
@romaricpascal romaricpascal linked a pull request Oct 7, 2024 that will close this issue
Make components use formatErrorMessage for error messages #5358
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romaricpascal romaricpascal

Labels
None yet
Projects
GOV.UK Design System cycle board
Status: Ready to release 🚀
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make components use formatErrorMessage for error messages alphagov/govuk-frontend
1 participant
@romaricpascal