You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Investigate if createAll could keep checking the type of the config it receives based on the Component it's initialising through another way than using the type of its defaults property.
Why
At the moment createAll's types use the defaults field of the component it receives as first argument to check the type of the configuration it receives as second argument. This implies:
That components needing a configuration need to expose these defaults as public
A constraint for components needing configuration to have defaults in the first place (even if empty/falsy), meaning extra code sent to the client
It'd be great if we could reduce these requirements
Who needs to work on this
Developers
Who needs to review this
Developers
Done when
We've investigated, assessed the impacts of a potential solution, and decided on whether to update our implementation or keep it as is.
The text was updated successfully, but these errors were encountered:
What
Investigate if
createAll
could keep checking the type of theconfig
it receives based on theComponent
it's initialising through another way than using the type of itsdefaults
property.Why
At the moment
createAll
's types use thedefaults
field of the component it receives as first argument to check the type of the configuration it receives as second argument. This implies:public
It'd be great if we could reduce these requirements
Who needs to work on this
Developers
Who needs to review this
Developers
Done when
The text was updated successfully, but these errors were encountered: