Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checkbox items to have explicit names #717

Closed
solidgoldpig opened this issue May 24, 2018 · 4 comments
Closed

Allow checkbox items to have explicit names #717

solidgoldpig opened this issue May 24, 2018 · 4 comments
Labels
feature request User requests a new feature

Comments

@solidgoldpig
Copy link
Contributor

I would like the ability to set the names of checkbox items explicitly rather than have them all share the same name.

This would allow me not to have to map values from one variable to another at the backend, but also to target the checkbox items on the clientside using the name (the latter being of less importantance since I could always pass an explicit id to achieve much the same effect)

Proposed code changes here:

solidgoldpig/govuk-frontend@master...checkboxes-items-can-have-explicit-names

@kr8n3r
Copy link

kr8n3r commented May 24, 2018

Hi @solidgoldpig
thanks for raising the issue. We're always looking to get the community's feedback as well as getting the community involved in the contribution.

If you're willing to raise a pull request for us to review it as a team, that'd be great.

@solidgoldpig
Copy link
Contributor Author

Hi @igloosi

Done.

@kr8n3r
Copy link

kr8n3r commented May 24, 2018

Thanks.
We'll aim to release this next week.

@kr8n3r
Copy link

kr8n3r commented May 30, 2018

Hi @solidgoldpig,
this has now been released in v0.0.30-alpha, so I will close the issue.

@kr8n3r kr8n3r closed this as completed May 30, 2018
@NickColley NickColley added the feature request User requests a new feature label Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request User requests a new feature
Projects
None yet
Development

No branches or pull requests

3 participants