Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add component principle around keeping to the 5px spacing scale #867

Closed
NickColley opened this issue Jul 4, 2018 · 1 comment
Closed

Add component principle around keeping to the 5px spacing scale #867

NickColley opened this issue Jul 4, 2018 · 1 comment
Labels
documentation User requests new documentation or improvements to existing documentation

Comments

@NickColley
Copy link
Contributor

When adjusting the tag component I mistakenly broke a rule around heights for our components.

We should document this somewhere to help people in the future.

See Ollie's helpful comments:
#855 (review)
#855 (comment)
@NickColley NickColley added the documentation User requests new documentation or improvements to existing documentation label Jul 4, 2018
@dashouse
Copy link

dashouse commented Jan 9, 2019

Closing this as it will be covered in #1121

@dashouse dashouse closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation User requests new documentation or improvements to existing documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NickColley @dashouse