Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

font-size in phase banner is being overridden by global styles #876

Closed
36degrees opened this issue Jul 5, 2018 · 0 comments · Fixed by #877
Closed

font-size in phase banner is being overridden by global styles #876

36degrees opened this issue Jul 5, 2018 · 0 comments · Fixed by #877
Assignees
@36degrees
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@36degrees
Copy link
Contributor

36degrees commented Jul 5, 2018 •
edited
Loading

When global styles are enabled, the phase banner uses the wrong font size.

It should be 16px:

screen shot 2018-07-05 at 13 26 01

But instead it uses the global

font-size of 19px:

screen shot 2018-07-05 at 13 25 47

I believe this is because the font-size of 16px is set on the parent .govuk-phase-banner, but p.govuk-phase-banner__content doesn't have a font-size set, so inherits the font size from the global paragraph styling.
@36degrees 36degrees added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Jul 5, 2018
@36degrees 36degrees self-assigned this Jul 5, 2018
@36degrees 36degrees mentioned this issue Jul 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@36degrees 36degrees

Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix phase banner being affected by global styles alphagov/govuk-frontend
1 participant
@36degrees