Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date input component outputs undefined classes #906

Closed
NickColley opened this issue Jul 16, 2018 · 0 comments
Closed

Date input component outputs undefined classes #906

NickColley opened this issue Jul 16, 2018 · 0 comments
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)

Comments

@NickColley
Copy link
Contributor

NickColley commented Jul 16, 2018 •
edited
Loading

The date input component outputs 'undefined' in the design system examples: https://design-system.service.gov.uk/components/date-input/

I believe this is due to the changes to deprecate automatic classes for the date input, where the logic to check for classes was removed:

https://github.com/alphagov/govuk-frontend/pull/857/files#diff-b8d80935ce12f0965849f63d8ef36897L44

(item.classes if item.classes)
@NickColley NickColley added the 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) label Jul 16, 2018
@NickColley NickColley mentioned this issue Jul 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NickColley