Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

details component not announcing collapsed/expanded state on iOS with VoiceOver #988

Closed
NickColley opened this issue Sep 7, 2018 · 3 comments · Fixed by #1523
Closed
Assignees

Comments

@NickColley
Copy link
Contributor

NickColley commented Sep 7, 2018

When using the progressive disclosure element VoiceOver on iOS in Safari doesn't announce that it is collapsed or expanded, despite the use of aria-expanded and others. All other screen readers are fine with it.

How would you expect it to work?

When on the trigger ("Help with nationality"), VoiceOver on iOS should say "collapsed, button" (like it does on macOS). When triggering it, it should say "expanded, button".

How does it work currently?

When on the trigger, VoiceOver only says "button". When triggered, it also only says "button".

Originally raised by @selfthinker on GOV.UK Elements: alphagov/govuk_elements#573

This will be an issue still since the code we are using is directly ported from GOV.UK Elements.

We may be able to resolve this by reducing the amount of polyfilling we are doing and relying more on the native details implementation in modern browsers, see alphagov/govuk_elements#572 for more details.

@NickColley
Copy link
Contributor Author

@NickColley
Copy link
Contributor Author

@NickColley
Copy link
Contributor Author

Some more details on aspects of the current polyfill: alphagov/govuk_elements#57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants