Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll out actionlint everywhere. #1361

Open
sengi opened this issue Jun 28, 2024 · 6 comments
Open

Roll out actionlint everywhere. #1361

sengi opened this issue Jun 28, 2024 · 6 comments
Assignees
Labels
security Security-related issue or enhancement (DO NOT USE PUBLIC ISSUES FOR VULN REPORTS obvs!)

Comments

@sengi
Copy link
Contributor

sengi commented Jun 28, 2024

We use GitHub Actions for a lot of important stuff and all(?) of our config for it is YAML. GHA's YAML interface is full of gotchas and footcannons, so a decent linter is a no-brainer.

We want actionlint to be a mandatory pre-merge check on all GOV.UK repos that use GitHub Actions.

(Removed Tasklists as these are deprecated)

@jasonBirchall
Copy link
Collaborator

Suggestion to use this tool:
https://github.com/alphagov/bulk-changer

@AgaDufrat
Copy link
Contributor

This was referenced Feb 25, 2025
@AgaDufrat
Copy link
Contributor

We should also update the docs so the check is added to any new repos: https://docs.publishing.service.gov.uk/manual/github-new-repo.html

@jasonBirchall
Copy link
Collaborator

@dj-maisy, what's the latest on this?

@AgaDufrat
Copy link
Contributor

There's also https://github.com/alphagov/bulk-merger which can be helpful.

@dj-maisy
Copy link
Member

dj-maisy commented Mar 7, 2025

This is now done, barring one final PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Security-related issue or enhancement (DO NOT USE PUBLIC ISSUES FOR VULN REPORTS obvs!)
Projects
None yet
Development

No branches or pull requests

4 participants