Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test across our supported browsers #325

Closed
NickColley opened this issue Sep 6, 2016 · 5 comments
Closed

Test across our supported browsers #325

NickColley opened this issue Sep 6, 2016 · 5 comments

Comments

@NickColley
Copy link
Contributor

NickColley commented Sep 6, 2016

We should run our tests in the different environments that we support https://www.gov.uk/service-manual/technology/designing-for-different-browsers-and-devices

This should not replace manual testing where appropriate but will catch simple issues like #323 and more complex issues in the future (if we used a ES5 feature without polyfilling for example)

I was thinking we could use sauce labs' free open source tier.

I'm looking into this but raising encase I don't have the time. 👍

@tombye
Copy link
Contributor

tombye commented Sep 6, 2016

@NickColley thanks for raising this. Can you give more detail on the ES5 feature issue so when we come to tackle this we know the full history of the issue?

@NickColley
Copy link
Contributor Author

NickColley commented Sep 6, 2016

@tombye just an example, I've stopped commits from being merged because they're using ES5 without the author realising it but we could easily miss that.

@tombye
Copy link
Contributor

tombye commented Sep 6, 2016

@NickColley anything you can link to? Might help future story writing to have examples to point to.

@NickColley
Copy link
Contributor Author

NickColley commented Sep 7, 2016

(Shared an example with @tombye privately since the purpose of this issue is not to make anyone feel like it's their fault but rather that anyone contributing could make this easy mistake)

@36degrees
Copy link
Contributor

36degrees commented Aug 30, 2018

Following the launch of the GOV.UK Design System, GOV.UK Frontend Toolkit will now only get major bug fixes and security patches, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants