Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics date regex is very specific #469

Closed
lewisnyman opened this issue Aug 1, 2018 · 2 comments
Closed

Google Analytics date regex is very specific #469

lewisnyman opened this issue Aug 1, 2018 · 2 comments

Comments

@lewisnyman
Copy link

Hi, I was just testing out the date regex that strips PII from Google Analytics events. It seems like the regex only captures dates in the format: XXXX-XX-XX

My initial test was XX/XX/XXXX, which wasn't being caught. It might be worth making the regex a bit more flexible?

@NickColley
Copy link
Contributor

Related conversation about flexibility: #466 (comment)

@36degrees
Copy link
Contributor

Following the launch of the GOV.UK Design System, GOV.UK Frontend Toolkit will now only get major bug fixes and security patches, so I'm going to close this.

GOV.UK Design System (and GOV.UK Frontend) does not provide any analytics functionality, and as far as I know there are currently no plans to provide this either as part of Frontend nor as a separate library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants