Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .env file to support storing private data #383

Merged
merged 1 commit into from
May 2, 2017
Merged

Conversation

edwardhorsford
Copy link
Contributor

Add a .env file for storing private data.

This is created from a template - so the real .env doesn't get committed to git.

This will be useful for teams integrating with APIs - like Notify.

Create .env file from template if it doesn't exist
Import items from .env using dotenv - good for storing private data
Copy link
Contributor

@tvararu tvararu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

You can force commit an empty .env file to version control. Would that be better than the creation script?

Edit: a small README / documentation blurb informing users that this feature exists could be useful.

@edwardhorsford
Copy link
Contributor Author

The advantage of the creation script is we can have a bit of a template / defaults - which I feel makes this more approachable.

@joelanman any thoughts on documentation for this? Do you think we could merge (ahead of training on Thursday) and have a think about where docs should go?

@tvararu
Copy link
Contributor

tvararu commented May 2, 2017

@edwardhorsford no reason not to have that if you commit the initial template to version control. On this branch:

mv lib/template.env .env
git add --force .env

(And revert start.js while keeping the refactored node_modules check)

@edwardhorsford
Copy link
Contributor Author

I think an advantage to this way of doing things is that if people create their own repos from the kit, when other users download from that repo, they'll too get a template env file.

What do you think?

@tvararu
Copy link
Contributor

tvararu commented May 2, 2017

@edwardhorsford for that situation it makes sense. Keep it then. 👌

@joelanman joelanman merged commit f7c9ffe into master May 2, 2017
@joelanman joelanman deleted the support_api_keys branch May 2, 2017 16:09
@edwardhorsford edwardhorsford mentioned this pull request May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants