Update cookies banner to align it with govuk-frontend #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgds
force-pushed
the
cookie-banner
branch
from
4597b37 to
9a401c5
Compare
maxgds
force-pushed
the
cookie-banner
branch
from
fbedc58 to
3f36902
Compare
maxgds
force-pushed
the
cookie-banner
branch
from
3f36902 to
2cf745f
Compare
maxgds
force-pushed
the
cookie-banner
branch
from
2cf745f to
99f67e7
Compare
maxgds
force-pushed
the
cookie-banner
branch
from
a33d12d to
10e72bb
Compare
maxgds
force-pushed
the
cookie-banner
branch
from
10e72bb to
2ecd674
Compare
maxgds
force-pushed
the
cookie-banner
branch
from
2ecd674 to
9316d31
Compare
andysellick
reviewed
Feb 15, 2021
app/assets/javascripts/govuk_publishing_components/components/cookie-banner.js
Outdated
Show resolved
Hide resolved
app/assets/javascripts/govuk_publishing_components/components/cookie-banner.js
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_cookie_banner.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_cookie_banner.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_cookie_banner.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_cookie_banner.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_cookie_banner.html.erb
Outdated
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_cookie-banner.scss
Outdated
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_cookie-banner.scss
Outdated
Show resolved
Hide resolved
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update cookies banner to inherit the Design System cookie banner component
Why
This brings our cookie banner in line with the design system in terms of look and feel and follows their guidance for compliance. The biggest differences:
Visual Changes
Before
After
Before
After