Add bottom border option to breadcrumb #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All good 👍🏼
(the visuals here have eg without:
|
chris-gds
approved these changes
Mar 1, 2021
Adding a border on the bottom of a breadcrumb is needed so this component can be used in alphagov/manuals-frontend.
injms
force-pushed
the
add-border-to-breadcrumb
branch
from
f80cfbc to
7d6d9a7
Compare
Merged
This was referenced Mar 11, 2021
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a parameter so a border can be added to the bottom of a breadcrumb.
Why
This is needed so this component can be used in alphagov/manuals-frontend.
Visual Changes
Desktop:
Mobile:
