Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github workflow pain points #32

Open
balmas opened this issue Jun 24, 2020 · 1 comment
Open

github workflow pain points #32

balmas opened this issue Jun 24, 2020 · 1 comment
Assignees

Comments

@balmas
Copy link
Member

balmas commented Jun 24, 2020

Some observations on remaining pain points with the current GitHub workflow:

  1. the qa and release builds are done manually on the local machine and not a clean environment
  2. the merge of master to qa is a little messy sometimes (maybe caused in part by previous point). Sometimes the node_modules or package-lock files are getting out of whack and it requires deleting the qa branch and starting over to get a clean build.
  3. when running tagged-commit, you have to push the branch and the tag separately, causing 2 duplicative travis invocations
  4. I would like a better solution for the environment files from the protected-config repo that are required for a functioning build. Current build process requires a local copy of the protected-config repo. We should probably move as much as we can from that file to our new config service and anything that remains should be handled via an encrypted secret.
  5. I'm not sure I like the production tags that are only the build number and no release information. (e.g. 20200618494)
@balmas
Copy link
Member Author

balmas commented Aug 24, 2020

1, 3 and 4 have been addressed by the switch to GitHub actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants