Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site with few problems #139

Closed
monzug opened this issue Oct 30, 2018 · 5 comments
Closed

site with few problems #139

monzug opened this issue Oct 30, 2018 · 5 comments
Labels
safari safari-specific issues verified

Comments

@monzug
Copy link

monzug commented Oct 30, 2018 •
edited
Loading

on this site
http://www.tradurreantico.it/latino/grammatica-latina/morfologia/verbo/verbo-eo-latino/
we have few problems

  1. double click does not work
  2. the style of the info panel or morphology panel is so different from same page in Firefox
    e.g. no navigation etc.
    screen shot 2018-10-30 at 3 10 26 pm
@monzug monzug added the safari safari-specific issues label Oct 30, 2018
@balmas balmas assigned irina060981 and unassigned balmas Oct 30, 2018
@balmas
Copy link
Member

balmas commented Oct 30, 2018

Assigning to @irina060981 to investigate. Style is probably related to #135 but the problem with the event not working is likely a new issue.

@irina060981
Copy link
Member

Styles - are from the same problem.
About double-click - it is an interesting issue about setting user-select:none to body.
It fails with this bug:
screen shot 2018-10-31 at 18 55 47

And it fails for doc.caretRangeFromPoint return null if this style is applied.
When I removed it from the styles (manual in Web Inspector) - double-click starts to work.

I am not sure if we should redefine such styles - anyway - for now for Safari I haven't found any answers about such a problem (with style priority).
I am confused so far

@irina060981
Copy link
Member

irina060981 commented Nov 17, 2018 •
edited
Loading

Solved upon #135

  1. Fix styles for user-select to body and double-click works now

screen shot 2018-11-19 at 16 45 21

  1. Styles for popup in Safari

screen shot 2018-11-17 at 22 54 25

This was referenced Nov 19, 2018
Merged
Merged
@balmas balmas assigned monzug and unassigned irina060981 Nov 19, 2018
@balmas
Copy link
Member

balmas commented Nov 19, 2018

ready for testing in build 2.1.0.9

@monzug
Copy link
Author

monzug commented Nov 26, 2018

tested in 2.1.0.10 - style and double click has been fixed. Thanks

@monzug monzug closed this as completed Nov 26, 2018
@monzug monzug removed their assignment Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
safari safari-specific issues verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@balmas @irina060981 @monzug