Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerize protoc-gen-go #225

Closed
prestonvasquez opened this issue Oct 4, 2022 · 2 comments
Closed

Dockerize protoc-gen-go #225

prestonvasquez opened this issue Oct 4, 2022 · 2 comments
Assignees
@con-mark
Labels
enhancement New feature or request hacktoberfest non-go
Milestone
Eng Dependency Cl...

Comments

@prestonvasquez
Copy link
Contributor

It would be helpful to new engineers to dockerize the protobuf compiler Make target and make it runnable with make proto. This would require a very light-weight Go image with this installed:

go install google.golang.org/protobuf/cmd/protoc-gen-go@latest

We should be able to run this with docker compose. Also update the docs/CONFIGURATION.md file to remove this required dependency.
@prestonvasquez prestonvasquez moved this to In Progress in Gidari MVP Oct 4, 2022
@prestonvasquez prestonvasquez moved this from In Progress to Scheduled in Gidari MVP Oct 4, 2022
@prestonvasquez prestonvasquez added this to the Eng Dependency Cleanup milestone Oct 4, 2022
@con-mark
Copy link

con-mark commented Oct 4, 2022

I can take this but might take me a couple of days :)

@prestonvasquez prestonvasquez moved this from Scheduled to In Progress in Gidari MVP Oct 4, 2022
@con-mark con-mark mentioned this issue Oct 4, 2022
Closed
@prestonvasquez prestonvasquez mentioned this issue Oct 6, 2022
Closed
@prestonvasquez
Copy link
Contributor Author

Since users of the library will be required to manage a protobuf version to run the binary, it doesn't make sense to decouple the proto-gen logic to a docker container. Engineers should install protobuf directly.

@prestonvasquez prestonvasquez closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2022
Repository owner moved this from In Progress to Done in Gidari MVP Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@con-mark con-mark

Labels
enhancement New feature or request hacktoberfest non-go
Projects
No open projects
Gidari MVP
Status: Done
Milestone
Eng Dependency Cleanup
Development

No branches or pull requests
2 participants
@prestonvasquez @con-mark