Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme does not change the color of text in tables #1134

Closed
aaamini opened this issue Jan 22, 2023 · 4 comments
Closed

Dark theme does not change the color of text in tables #1134

aaamini opened this issue Jan 22, 2023 · 4 comments
Labels

Comments

@aaamini
Copy link

aaamini commented Jan 22, 2023

It seems that there is a bug perhaps in the Material Bootstrap (?) regarding the dark theme and the color of the text in tables.

Specifically, the text remains black in tables when changing to dark theme making the text invisible. The setting seems to be in _tables.scss which is not included in al-folio.

Here is what the table looks like before any modifications:

before

Here is it is after manually changing the color to var(--global-text-color); in the inspector:

after

Is it possible to include _tables.scss so that this can be fixed?

@aaamini aaamini added the bug label Jan 22, 2023
@tostenzel
Copy link

tostenzel commented Mar 11, 2023

There is a similar problem with the figure captions in the distill style blogposts. Yet, I don't know whether the reason is the same.

@george-gca
Copy link
Collaborator

george-gca commented Apr 25, 2023

Does #1283 fixes this @aaamini?

@lancewilhelm
Copy link
Contributor

The issue appears to lie with how the tables are styled when the page is dark. When dark mode is toggled, the tables are classed as .table-dark. However, upon loading of the page, the tables are classed as .table. The script no_defer.js appears to address this issue for tables upon page load, but it does not class tables in news or cards.

@george-gca
Copy link
Collaborator

Fixed this in #1424, but there's something bothering me. The background of the dark mode should also be transparent. Currently it is like this:

image

while in light mode is like this:

image

I'll try to fix this in the same branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants