Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Bar Height #7

Open
mzekrallah opened this issue Apr 20, 2015 · 7 comments
Open

Progress Bar Height #7

mzekrallah opened this issue Apr 20, 2015 · 7 comments

Comments

@mzekrallah
Copy link

Thanks for the great control .. what is the easiest way to adjust the progress bar height ? I tried to skim through the code but couldn't find a suitable place .. in IB, it is hard-coded to 2 pixels but the value is disabled for editing .. Thanks

@mzekrallah
Copy link
Author

I just noticed this is inheriting UIProgressView :(

I tried below workaround to increase the height of the bar :
http://stackoverflow.com/questions/18717895/progress-view-height-in-ios-7

It solves it by adding a height constraint to the control in IB .. the height worked but 2 issues appeared :

  1. the bar doesn't animate the first half when you click start .. it immediately jumps there .. after the first progress tick has happened things go back to normal .. its just the first tick jumps immediately ..

  2. There is a rounded corner in the start of the bar .. not like its end ..

See below pic for more details ..

screenshot 2015-04-20 09 12 52

Would appreciate your feedback ..
Thanks

@mzekrallah
Copy link
Author

weird thing is that two issues mentioned above only happens to the first bar not the second ..

@alskipp
Copy link
Owner

alskipp commented Apr 20, 2015

Hi @mzekrallah,
I've just added a feature branch that doesn't subclass UIProgressView (this should fix the resizing issue).
https://github.com/alskipp/ASProgressPopUpView/tree/uiview_subclass

It is work in progress, but please give it a try.

All the best,
Al

@mzekrallah
Copy link
Author

I just checked it out .. awesome bro 👍 .. actually ditching UIProgressView would be for the ultimate good of the control .. since there are many things in UIProgressView that can't be altered .. also, in UIVIew approach there are endless possibilities to what you can attach to the bar and maybe upgrade t's entire behaviour from a progress view to something more of a timer which is actually my use case ..

By the way, I have ported this awesome control into Xamarin.iOS and I will be sharing that soon on github .. I'm sure lots of xamarin guys would love it ..

Thanks again

@mzekrallah
Copy link
Author

By the way @alskipp , would you eventually move towards the UIView subclass branch or stick with the UIProgressView ? I would like to know so that I know on which branch I should be doing my porting and extended functionality so i'm aligned with your directions on this great control ... Thanks

@alskipp
Copy link
Owner

alskipp commented Apr 22, 2015

Hi @mzekrallah,
It needs a bit more work to clean the code up, but I think it would make sense to eventually merge the UIView subclass branch into master.

@mzekrallah
Copy link
Author

great to hear 👍 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants