Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to modify API basePath via annotations #29

Closed
aleks-fofanov opened this issue Oct 10, 2016 · 2 comments · Fixed by #30
Closed

Allow to modify API basePath via annotations #29

aleks-fofanov opened this issue Oct 10, 2016 · 2 comments · Fixed by #30

Comments

@aleks-fofanov
Copy link
Contributor

Hey,

First of all, thanks for the plugin!

Having the API basePath derived from Configure::read('App.base') is good, but if you have an application where your API endpoints are prefixed (e.g. /api) and this app also serves static content or crud as the webpages this might be an issue.
So, having an option to define API basePath via annotations might help. Basically, if basePath is defined via annotations we use it or App.base otherwise.

The fix is quite trivial but I can create a PR if needed.
Thanks!
@bravo-kernel
Copy link
Contributor

I believe you are the second person mentioning this so feel free to submit a PR and we'll take it from there.

@aleks-fofanov aleks-fofanov mentioned this issue Oct 10, 2016
Merged
@aleks-fofanov
Copy link
Contributor Author

Done #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to modify API basePath via annoations
2 participants
@bravo-kernel @aleks-fofanov