Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should FONTSIZE be optional? #64

Closed
chris1010010 opened this issue Nov 11, 2019 · 14 comments
Closed

Should FONTSIZE be optional? #64

chris1010010 opened this issue Nov 11, 2019 · 14 comments

Comments

@chris1010010
Copy link

At the moment FONTSIZE in TextStyle is required.
If the font size is not available, no other style attributes can be used. Is that by design?
For example, it is not possible to store FONTCOLOR unless also FONTSIZE is provided.

@urieli
Copy link

urieli commented Nov 11, 2019

I fully agree that this should be optional.
Especially since it is sometimes impossible to know the font size: if the image has no DPI associated, there is no way to know what the printed font size is.

@artunit
Copy link
Member

artunit commented Dec 9, 2019

Thanks for raising this - I have put it on the agenda for the upcoming 2019-12-13 Board meeting.

@artunit
Copy link
Member

artunit commented Dec 16, 2019

As per the 2019-12-13 Board meeting, it is proposed to change FONTSIZE from required to optional, i.e.:

<xsd:attribute name="FONTSIZE" type="xsd:float" use="required">
  <xsd:annotation>
    <xsd:documentation>The font size, in points (1/72 of an inch).</xsd:documentation>
  </xsd:annotation>
</xsd:attribute>

to:

<xsd:attribute name="FONTSIZE" type="xsd:float" use="optional">
  <xsd:annotation>
    <xsd:documentation>The font size, in points (1/72 of an inch).</xsd:documentation>
  </xsd:annotation>
</xsd:attribute>

@artunit
Copy link
Member

artunit commented Feb 15, 2020

ACCEPT

9 similar comments
@cipriandinu
Copy link
Member

ACCEPT

@splet
Copy link

splet commented Feb 17, 2020

ACCEPT

@cneud
Copy link
Member

cneud commented Feb 17, 2020

ACCEPT

@Ra1phM
Copy link
Member

Ra1phM commented Feb 17, 2020

ACCEPT

@ntra00
Copy link
Member

ntra00 commented Feb 19, 2020

ACCEPT

@bkgeig
Copy link
Member

bkgeig commented Feb 19, 2020

ACCEPT

@cowboyMontana
Copy link
Member

ACCEPT

@jukervin
Copy link
Member

ACCEPT

@rajubln
Copy link

rajubln commented May 22, 2020

ACCEPT

@cneud cneud changed the title Should FONTSIZE be required? Should FONTSIZE be optional? May 24, 2020
@artunit
Copy link
Member

artunit commented Sep 2, 2020

Added in v4.2, released August 2020.

@artunit artunit closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests