Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add building instructions for Windows #151

Closed
Immersion95 opened this issue Jul 11, 2024 · 2 comments · Fixed by #152
Closed

[Request] Add building instructions for Windows #151

Immersion95 opened this issue Jul 11, 2024 · 2 comments · Fixed by #152

Comments

@Immersion95
Copy link
Contributor

Immersion95 commented Jul 11, 2024

Rust can't build asm-hashes with MSVC at the moment --->See here

It has to be built with GNU, is it possible to add this command in the build instructions :

  • cargo build --release --target x86_64-pc-windows-gnu

Of course you have to add MSYS2-mingw-w64 to the variable PATH to use gcc.exe

@Immersion95 Immersion95 changed the title [Request] Add building instruction for Windows [Request] Add building instructions for Windows Jul 11, 2024
@alucryd
Copy link
Owner

alucryd commented Jul 11, 2024

Thanks for the heads up. I have no Windows machine so my only option is GNU and I didn't catch that one. I'll add build instructions, an alternative would be to disable the enable-asm feature when building with MSVC, you won't see any difference if you use CRC as your default hash, as asm-hashes is only used with MD5 and SHA1.

@Immersion95
Copy link
Contributor Author

Thanks for the heads up. I have no Windows machine so my only option is GNU and I didn't catch that one. I'll add build instructions, an alternative would be to disable the enable-asm feature when building with MSVC, you won't see any difference if you use CRC as your default hash, as asm-hashes is only used with MD5 and SHA1.

Yes it works without it too :)

  • cargo build --release --no-default-features --features use-rustls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants