Error Parsing YAML File

[ossie-git]

Hi,

Thank you for developing yaa. While trying out yaa, I ran into the following error:

git clone https://github.com/trailofbits/semgrep-rules/
cd semgrep-rules/
yaa index .

and it would give me:

Indexing.Error parsing YAML file yaml/ansible/apt-key-unencrypted-url.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/apt-key-unencrypted-url.yaml: yaml: line 32: found unknown escape character
Indexing..Error parsing YAML file yaml/ansible/apt-key-validate-certs-disabled.test.yaml: yaml: unmarshal errors:
  line 3: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/apt-unencrypted-url.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/apt-unencrypted-url.yaml: yaml: line 32: found unknown escape character
Error parsing YAML file yaml/ansible/dnf-unencrypted-url.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/dnf-unencrypted-url.yaml: yaml: line 36: found unknown escape character
Error parsing YAML file yaml/ansible/dnf-validate-certs-disabled.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/get-url-unencrypted-url.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/get-url-unencrypted-url.yaml: yaml: line 42: found unknown escape character
Error parsing YAML file yaml/ansible/get-url-validate-certs-disabled.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/rpm-key-unencrypted-url.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/rpm-key-unencrypted-url.yaml: yaml: line 32: found unknown escape character
Error parsing YAML file yaml/ansible/rpm-key-validate-certs-disabled.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/unarchive-unencrypted-url.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/unarchive-unencrypted-url.yaml: yaml: line 32: found unknown escape character
Error parsing YAML file yaml/ansible/unarchive-validate-certs-disabled.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/wrm-cert-validation-ignore.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/yum-unencrypted-url.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/yum-unencrypted-url.yaml: yaml: line 33: found unknown escape character
Error parsing YAML file yaml/ansible/yum-validate-certs-disabled.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/zypper-repository-unencrypted-url.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/zypper-repository-unencrypted-url.yaml: yaml: line 32: found unknown escape character
Error parsing YAML file yaml/ansible/zypper-unencrypted-url.test.yaml: yaml: unmarshal errors:
  line 2: cannot unmarshal !!seq into map[string]interface {}
Error parsing YAML file yaml/ansible/zypper-unencrypted-url.yaml: yaml: line 33: found unknown escape character
Done!

here is one of the files that it chokes on:

rules:
  - id: apt-unencrypted-url
    message: Found apt deb with unencrypted URL (e.g. HTTP, FTP, etc.)
    languages: [yaml]
    severity: WARNING
    metadata:
      category: security
      cwe: "CWE-319: Cleartext Transmission of Sensitive Information"
      subcategory: [audit]
      technology: [ansible, apt]
      confidence: HIGH
      likelihood: HIGH
      impact: HIGH
      references:
        - https://docs.ansible.com/ansible/latest/collections/ansible/builtin/apt_module.html#parameter-deb
    patterns:
      - pattern-inside: |
          $APT:
            ...
      - metavariable-pattern:
          metavariable: $APT
          pattern-either:
            - pattern: apt
            - pattern: ansible.builtin.apt
      - pattern: "$KEY: '$VALUE'"
      - metavariable-pattern:
          metavariable: $KEY
          pattern-either:
            - pattern: deb
      - metavariable-regex:
          metavariable: $VALUE
          regex: "(?i)^(http|ftp):\/\/.*"

It looks like it chokes on the regex line (this is one of the reasons but I think there are others). Any ideas? Thanks

[alwashali]

Thank you for reporting this
I will look into it