Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for not valid letter #8

Open
Konstantin8105 opened this issue Sep 1, 2018 · 1 comment
Open

Test for not valid letter #8

Konstantin8105 opened this issue Sep 1, 2018 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed test-fix

Comments

@Konstantin8105
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Now, we haven't test for not valid letter.
For example, China hieroglyph or Sweden letter.

Describe the solution you'd like
Add test in file morse_test.go

Describe alternatives you've considered
??

Additional context
Prepared PR #7
@alwindoss
Copy link
Owner

We should fail the Encode when there are characters that are not recognized by our library. Today it ignores them and translates only those characters that it recognizes

@alwindoss alwindoss added help wanted Extra attention is needed bug Something isn't working labels Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed test-fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alwindoss @Konstantin8105