Hides the contact icon if empty in config #314
Conversation
| @@ -13,7 +13,9 @@ type Props = { | |||
| const Contacts = ({ contacts }: Props) => ( | |||
| <div className={styles['contacts']}> | |||
| <ul className={styles['contacts__list']}> | |||
| {Object.keys(contacts).map((name) => ( | |||
| {Object.keys(contacts).map((name) => | |||
| contacts[name] === '' ? ('') : | |||
There was a problem hiding this comment.
I think we should just check if contacts[name] is truthy here - that way, we can catch it if the value is undefined or null, too.
Also, use null instead of an empty string for the empty case. I think React still creates a <span> for an empty string, which we don't want.
This line could be rewritten like: !contacts[name] ? null :
There was a problem hiding this comment.
Thank you for the feedback :) I fixed this but Prettier changed way more than expected. Sadly, I did not notice before pushing. To avoid messing up the git history I can create a new pull request containing only one commit if wanted?
There was a problem hiding this comment.
Sure, if you make a new PR just close this one and refer to it from the new one!
There was a problem hiding this comment.
Code and also the git history in my fork is now fixed. Again thank you for the comments :)
|
Thanks! Made a few edits to satisfy lint. |
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 35 35
Lines 144 144
Branches 8 9 +1
=======================================
Hits 140 140
Misses 4 4
Continue to review full report at Codecov.
|
Description
Hi, thank you for this awesome starter!
I made this small change for my own blog and figured it could be useful for others as well, as I’m probably not the only user that don’t need all the available contact options. It’s a simple if condition when the contacts settings is looped. If it’s
‘’(empty) in the config the<li>won’t be returned, thus not showing the icon with a url without the username.